Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Drupal 8.5.3 #230

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Update to Drupal 8.5.3 #230

merged 2 commits into from
Apr 25, 2018

Conversation

fureigh
Copy link
Contributor

@fureigh fureigh commented Apr 25, 2018

Addresses the vulnerability mentioned in https://www.drupal.org/SA-CORE-2018-004.

@fureigh fureigh requested a review from cmc333333 April 25, 2018 17:27
@fureigh
Copy link
Contributor Author

fureigh commented Apr 25, 2018

@cmc333333 We may want to rethink #223's approach to RewriteRule, as any changes to web/.htaccess risk being overwritten. One alternative is to clearly document the divergence.

Copy link
Contributor

@cmc333333 cmc333333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- Drupal and its deps are the only being updated.

@cmc333333
Copy link
Contributor

Womp womp. I wonder if we could implement the htacces in a subdirectory so that it wouldn't conflict with Drupal's desire.

@fureigh fureigh merged commit c4fc00f into master Apr 25, 2018
@fureigh fureigh deleted the update-to-drupal-8.5.3 branch April 25, 2018 17:40
@cmc333333
Copy link
Contributor

Related to the htaccess issue: acquia/blt#1135

Using a subdir won't work as Drupal's htaccess would need to be modified to allow that subdir to be read...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants