fix(rspack): allow typechecking during serve #29267 #30558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 982465e.
☁️ Nx Cloud last updated this comment at |
leosvelperez
reviewed
Apr 1, 2025
packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.ts
Outdated
Show resolved
Hide resolved
Coly010
changed the title
Coly010
force-pushed
the
rspack/allow-typechecking-during-serve
branch
from
08c1734 to
982465e
Compare
leosvelperez
approved these changes
Apr 2, 2025
jaysoo
pushed a commit
that referenced
this pull request
Apr 2, 2025
## Current Behavior The `NxRspackAppPlugin` and `NxWebpackAppPlugin` will not provide typechecking if using TS Solution setup because it already has a typecheck target. However, this means that typechecking will not be run during serve. ## Expected Behavior Allow typechecking to run during serve even with TS Solution setup ## Related Issue(s) Fixes #29267
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
NxRspackAppPluginandNxWebpackAppPluginwill not provide typechecking if using TS Solution setup because it already has a typecheck target.However, this means that typechecking will not be run during serve.
Expected Behavior
Allow typechecking to run during serve even with TS Solution setup
Related Issue(s)
Fixes #29267