fix(core): resolve subpath patterns in package exports correctly when constructing graph #30511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constructing graph
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 4c7872c.
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
Apr 1, 2025
jaysoo
pushed a commit
that referenced
this pull request
Apr 2, 2025
… constructing graph (#30511) ## Current Behavior When a package has a subpath pattern like the following: ```json { "exports": { "./*": { "types": "./dist/lib/*/index.d.ts", "import": "./dist/lib/*/index.js", "default": "./dist/lib/*/index.js" } } } ``` When constructing the graph the project is not picked as a dependency of others projects that import from the package using a path that matches that subpath pattern. This is currently happening because the current resolution is wrongly using `minimatch` to match those patterns instead of the [Node.js spec for resolving subpath patterns](https://nodejs.org/docs/latest-v22.x/api/esm.html#resolution-algorithm-specification). ## Expected Behavior Subpath patterns should be processed after the [Node.js spec](https://nodejs.org/docs/latest-v22.x/api/esm.html#resolution-algorithm-specification) and the graph should pick up dependencies when used. ## Related Issue(s) Fixes #30342
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When a package has a subpath pattern like the following:
{ "exports": { "./*": { "types": "./dist/lib/*/index.d.ts", "import": "./dist/lib/*/index.js", "default": "./dist/lib/*/index.js" } } }When constructing the graph the project is not picked as a dependency of others projects that import from the package using a path that matches that subpath pattern. This is currently happening because the current resolution is wrongly using
minimatchto match those patterns instead of the Node.js spec for resolving subpath patterns.Expected Behavior
Subpath patterns should be processed after the Node.js spec and the graph should pick up dependencies when used.
Related Issue(s)
Fixes #30342