Skip to content

fix(core): add more detection for ci platforms #30507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

Cammisuli
Copy link
Member

Current Behavior

There are certain env variables that we do not check when detecting Jenkins for out isCi() function

Expected Behavior

Jenkins should be properly detected in more cases.

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested a review from a team as a code owner March 26, 2025 14:29
@Cammisuli Cammisuli requested a review from FrozenPandaz March 26, 2025 14:29
Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 2:30pm

Copy link

nx-cloud bot commented Mar 26, 2025

View your CI Pipeline Execution ↗ for commit 407ee74.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 40m 15s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=ab311... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 2m 41s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-26 15:16:30 UTC

@Cammisuli Cammisuli enabled auto-merge (squash) March 26, 2025 14:50
@Cammisuli Cammisuli merged commit e6d8b39 into master Mar 26, 2025
12 checks passed
@Cammisuli Cammisuli deleted the feature/nxc-665-jenkins-not-detected-in-ci branch March 26, 2025 15:16
Copy link

github-actions bot commented Apr 1, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants