fix(js): do not add typecheck target if tsc is used for build #30211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 6c8012b.
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Feb 27, 2025
jaysoo
force-pushed
the
fix/js-skip-typecheck-for-tsc
branch
from
e1aba2e to
865c472
Compare
jaysoo
force-pushed
the
fix/js-skip-typecheck-for-tsc
branch
from
865c472 to
fd6086c
Compare
leosvelperez
approved these changes
Feb 28, 2025
isaacplmann
approved these changes
Feb 28, 2025
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
jaysoo
force-pushed
the
fix/js-skip-typecheck-for-tsc
branch
from
155abf8 to
87cb863
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for skipping
typechecktargets when using@nx/js/typescript. Insidetsconfig.jsonfor each project, you can setnx.addTypecheckTargettofalseto not infertypecheck.This allows use to skip
typecheckfor JS projects usingtscto build. Sincetscis already used during build, we don't need to runtypecheckthat is just duplicated work.Current Behavior
JS libs using
tscto build will do typechecking twice. Once duringbuildand once duringtypecheck.Expected Behavior
JS libs using
tscdo not infertypecheckby default. And users can change this behavior by settingnx.addTypecheckTargetintsconfig.json.Related Issue(s)
Fixes #