fix(devkit): handle missing include and exclude in tsconfig options when updating tsconfig to support js
#30073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns when updating tsconfig to support js
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit cac52fc.
☁️ Nx Cloud last updated this comment at |
JamesHenry
approved these changes
Feb 18, 2025
jaysoo
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ns when updating tsconfig to support js (#30073) ## Current Behavior The `updateTsConfigsToJs` helper from `@nx/devkit` doesn't handle tsconfig files without the `include` or `exclude` properties. ## Expected Behavior The `updateTsConfigsToJs` helper from `@nx/devkit` should handle tsconfig files without the `include` or `exclude` properties. ## Related Issue(s) Fixes #30067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
updateTsConfigsToJshelper from@nx/devkitdoesn't handle tsconfig files without theincludeorexcludeproperties.Expected Behavior
The
updateTsConfigsToJshelper from@nx/devkitshould handle tsconfig files without theincludeorexcludeproperties.Related Issue(s)
Fixes #30067