feat(module-federation): add NxModuleFederationPlugin for inferred usage #30003
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 6203d88.
☁️ Nx Cloud last updated this comment at |
Coly010
force-pushed
the
mf/rspack-mf-plugin
branch
3 times, most recently
from
4d7a22f to
0174987
Compare
| // in addition to writing into the stdout stream, also show error directly in console | ||
| // so the error is easily discoverable. 'ERROR in' is the key word to search in webpack output. | ||
| if (stdoutString.includes('ERROR in')) { | ||
| console.log(stdoutString); |
There was a problem hiding this comment.
should this be logged via console.error?
There was a problem hiding this comment.
This was copied from the existing build-static-remotes function that we have for executor usage. I think this is fine for now.
There was a problem hiding this comment.
Do you not think it is a better DX for errors to be logged via console.error?
There was a problem hiding this comment.
Could be a good opportunity to change it 🤔 @jaysoo you originally added this logic for handling errors - is there a reason you used console.log and not console.error?
Coly010
force-pushed
the
mf/rspack-mf-plugin
branch
from
0174987 to
6203d88
Compare
Current Behaviour
Currently, Module Federation with Nx is forced to use executors to provide the best DX.
Expected Behaviour
As part of the transition to inferred targets, we will need Rspack plugins that replicates the DX provided by our executors.
Add
NxModuleFederationPluginandNxModuleFederationDevServerPluginto handle this.