Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(testing): migrate jest to picocolors #29561

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Phillip9587
Copy link
Contributor

migrates @nx/jest from chalk to picocolors

Part of es-tooling/ecosystem-cleanup#117

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@Phillip9587 Phillip9587 requested review from a team as code owners January 9, 2025 11:44
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 2:21pm

Copy link

nx-cloud bot commented Jan 9, 2025

View your CI Pipeline Execution ↗ for commit 3b95b72.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 33m 28s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 56s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=f98ae... ✅ Succeeded 22s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 21s View ↗
nx documentation --no-dte ✅ Succeeded 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-09 14:59:05 UTC

@Phillip9587 Phillip9587 force-pushed the jest-picocolors branch 3 times, most recently from e5dd4ac to f0333d5 Compare January 9, 2025 11:47
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Left just one comment to simplify the eslint config.

packages/jest/.eslintrc.json Show resolved Hide resolved
migrates `@nx/jest` from `chalk` to `picocolors`
@leosvelperez leosvelperez merged commit b491489 into nrwl:master Jan 9, 2025
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants