Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(misc): adding nx live episode w Mike and some fixes #27837

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

ZackDeRose
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@ZackDeRose ZackDeRose self-assigned this Sep 9, 2024
@ZackDeRose ZackDeRose requested review from a team as code owners September 9, 2024 19:05
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 9, 2024 8:55pm

@ZackDeRose ZackDeRose force-pushed the nx-live-mike-introduction branch from 1f53449 to 287fee4 Compare September 9, 2024 19:06
@@ -3,8 +3,9 @@ title: Better security with Personal Access Tokens
slug: personal-access-tokens
authors: ['Philip Fulcher']
tags: [nx-cloud]
cover_image: /blog/images/2024-09-06/personal-access-tokens-header.png
cover_image: /blog/images/2024-09-10/personal-access-tokens-header.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use personal-access-tokens-header.avif can we add it back?
The .png file should also be there so that it can be used as the file for OG image.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool added it back. btw @ndcunningham - it looked like there were some type errors around the usage of the ogImage properties on master? it was in blog/[slug]/page.tsx that I saw it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the file has been deleted can you restore the file?

@ZackDeRose ZackDeRose force-pushed the nx-live-mike-introduction branch from 959d209 to a242a95 Compare September 9, 2024 20:25
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrozenPandaz FrozenPandaz merged commit 9b3a960 into master Sep 9, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the nx-live-mike-introduction branch September 9, 2024 21:00
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants