feat(release): allow local dependency version protocols to be preserved, pnpm publish support #27787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 151faf2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
1 task
JamesHenry
commented
Sep 5, 2024
| @@ -993,7 +999,8 @@ let pmVersion: string | undefined; | |||
| const localPackageProtocols = [ | |||
| 'file:', // all package managers | |||
| 'workspace:', // not npm | |||
| 'portal:', // modern yarn only | |||
There was a problem hiding this comment.
I had jumped the gun on this being there in a previous PR, because we don't support it at the project graph level right now, so it's already not an applicable setup
JamesHenry
changed the title
JamesHenry
force-pushed
the
release-version-preserveLocalDependencyProtocols
branch
2 times, most recently
from
968a389 to
74fc79f
Compare
…ed, pnpm publish support
JamesHenry
force-pushed
the
release-version-preserveLocalDependencyProtocols
branch
from
228f1ef to
151faf2
Compare
4 tasks
fahslaj
approved these changes
Sep 10, 2024
JamesHenry
deleted the
release-version-preserveLocalDependencyProtocols
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We always update relevant dependency versions to their new semantic version as part of versioning and we only ever publish using
npm publish.Expected Behavior
We allow for the user to configure a preference for preserving local dependency protocols (such as
file:andworkspace:) when versioning, whilst maintaining all other aspects of the versioning logic.This would allow them to combine it with
pnpm publish, which would handle the dynamic replacement of those values during the packing step. Therefore, when the user is usingpnpm, we now preferentially publish usingpnpm publishinstead ofnpm publish.Related Issue(s)
Fixes #