Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use durations from task history to schedule tasks #27783

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 27 additions & 24 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nx/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ nom = '7.1.3'
regex = "1.9.1"
rayon = "1.7.0"
rkyv = { version = "0.7", features = ["validation"] }
rusqlite = { version = "0.29.0", features = ["bundled", "array", "vtab", "wasm32-wasi-vfs"] }
rusqlite = { version = "0.32.1", features = ["bundled", "array", "vtab", "wasm32-wasi-vfs"] }
thiserror = "1.0.40"
tracing = "0.1.37"
tracing-subscriber = { version = "0.3.17", features = ["env-filter"] }
Expand Down
15 changes: 14 additions & 1 deletion packages/nx/src/daemon/client/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {
DaemonProjectGraphError,
ProjectGraphError,
} from '../../project-graph/error-types';
import { IS_WASM, NxWorkspaceFiles, TaskRun } from '../../native';
import { IS_WASM, NxWorkspaceFiles, TaskRun, TaskTarget } from '../../native';
import { HandleGlobMessage } from '../message-types/glob';
import {
GET_NX_WORKSPACE_FILES,
Expand All @@ -44,7 +44,9 @@ import {
} from '../message-types/get-files-in-directory';
import { HASH_GLOB, HandleHashGlobMessage } from '../message-types/hash-glob';
import {
GET_ESTIMATED_TASK_TIMINGS,
GET_FLAKY_TASKS,
HandleGetEstimatedTaskTimings,
HandleGetFlakyTasks,
HandleRecordTaskRunsMessage,
RECORD_TASK_RUNS,
Expand Down Expand Up @@ -357,6 +359,17 @@ export class DaemonClient {
return this.sendToDaemonViaQueue(message);
}

async getEstimatedTaskTimings(
targets: TaskTarget[]
): Promise<Record<string, number>> {
const message: HandleGetEstimatedTaskTimings = {
type: GET_ESTIMATED_TASK_TIMINGS,
targets,
};

return this.sendToDaemonViaQueue(message);
}

recordTaskRuns(taskRuns: TaskRun[]): Promise<void> {
const message: HandleRecordTaskRunsMessage = {
type: RECORD_TASK_RUNS,
Expand Down
30 changes: 23 additions & 7 deletions packages/nx/src/daemon/message-types/task-history.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,24 @@
import type { TaskRun } from '../../native';
import type { TaskRun, TaskTarget } from '../../native';

export const GET_FLAKY_TASKS = 'GET_FLAKY_TASKS' as const;
export const GET_ESTIMATED_TASK_TIMINGS = 'GET_ESTIMATED_TASK_TIMINGS' as const;
export const RECORD_TASK_RUNS = 'RECORD_TASK_RUNS' as const;

export type HandleGetFlakyTasks = {
type: typeof GET_FLAKY_TASKS;
hashes: string[];
};

export type HandleGetEstimatedTaskTimings = {
type: typeof GET_ESTIMATED_TASK_TIMINGS;
targets: TaskTarget[];
};

export type HandleRecordTaskRunsMessage = {
type: typeof RECORD_TASK_RUNS;
taskRuns: TaskRun[];
};

export function isHandleGetFlakyTasksMessage(
message: unknown
): message is HandleGetFlakyTasks {
Expand All @@ -18,12 +30,16 @@ export function isHandleGetFlakyTasksMessage(
);
}

export const RECORD_TASK_RUNS = 'RECORD_TASK_RUNS' as const;

export type HandleRecordTaskRunsMessage = {
type: typeof RECORD_TASK_RUNS;
taskRuns: TaskRun[];
};
export function isHandleGetEstimatedTaskTimings(
message: unknown
): message is HandleGetEstimatedTaskTimings {
return (
typeof message === 'object' &&
message !== null &&
'type' in message &&
message['type'] === GET_ESTIMATED_TASK_TIMINGS
);
}

export function isHandleWriteTaskRunsToHistoryMessage(
message: unknown
Expand Down
22 changes: 11 additions & 11 deletions packages/nx/src/daemon/server/handle-task-history.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
import { TaskRun } from '../../native';
import { TaskHistory } from '../../utils/task-history';

let taskHistory: TaskHistory;

function getTaskHistory() {
if (!taskHistory) {
taskHistory = new TaskHistory();
}
return taskHistory;
}
import { getTaskHistory } from '../../utils/task-history';
import type { TaskRun, TaskTarget } from '../../native';

export async function handleRecordTaskRuns(taskRuns: TaskRun[]) {
const taskHistory = getTaskHistory();
Expand All @@ -27,3 +18,12 @@ export async function handleGetFlakyTasks(hashes: string[]) {
description: 'handleGetFlakyTasks',
};
}

export async function handleGetEstimatedTaskTimings(targets: TaskTarget[]) {
const taskHistory = getTaskHistory();
const history = await taskHistory.getEstimatedTaskTimings(targets);
return {
response: JSON.stringify(history),
description: 'handleGetEstimatedTaskTimings',
};
}
13 changes: 11 additions & 2 deletions packages/nx/src/daemon/server/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,17 @@ import { handleGetFilesInDirectory } from './handle-get-files-in-directory';
import { HASH_GLOB, isHandleHashGlobMessage } from '../message-types/hash-glob';
import { handleHashGlob } from './handle-hash-glob';
import {
GET_ESTIMATED_TASK_TIMINGS,
GET_FLAKY_TASKS,
isHandleGetEstimatedTaskTimings,
isHandleGetFlakyTasksMessage,
isHandleWriteTaskRunsToHistoryMessage,
RECORD_TASK_RUNS,
} from '../message-types/task-history';
import {
handleRecordTaskRuns,
handleGetFlakyTasks,
handleGetEstimatedTaskTimings,
} from './handle-task-history';
import { isHandleForceShutdownMessage } from '../message-types/force-shutdown';
import { handleForceShutdown } from './handle-force-shutdown';
Expand Down Expand Up @@ -240,11 +245,15 @@ async function handleMessage(socket, data: string) {
handleHashGlob(payload.globs, payload.exclude)
);
} else if (isHandleGetFlakyTasksMessage(payload)) {
await handleResult(socket, 'GET_TASK_HISTORY_FOR_HASHES', () =>
await handleResult(socket, GET_FLAKY_TASKS, () =>
handleGetFlakyTasks(payload.hashes)
);
} else if (isHandleGetEstimatedTaskTimings(payload)) {
await handleResult(socket, GET_ESTIMATED_TASK_TIMINGS, () =>
handleGetEstimatedTaskTimings(payload.targets)
);
} else if (isHandleWriteTaskRunsToHistoryMessage(payload)) {
await handleResult(socket, 'WRITE_TASK_RUNS_TO_HISTORY', () =>
await handleResult(socket, RECORD_TASK_RUNS, () =>
handleRecordTaskRuns(payload.taskRuns)
);
} else if (isHandleForceShutdownMessage(payload)) {
Expand Down
2 changes: 0 additions & 2 deletions packages/nx/src/generators/tree.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ import { logger } from '../utils/logger';
import { output } from '../utils/output';
import { dirname, join, relative, sep } from 'path';
import * as chalk from 'chalk';
import { gt } from 'semver';
import { nxVersion } from '../utils/versions';

/**
* Options to set when writing a file in the Virtual file system tree.
Expand Down
1 change: 1 addition & 0 deletions packages/nx/src/native/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export declare class NxTaskHistory {
constructor(db: ExternalObject<Connection>)
recordTaskRuns(taskRuns: Array<TaskRun>): void
getFlakyTasks(hashes: Array<string>): Array<string>
getEstimatedTaskTimings(targets: Array<TaskTarget>): Record<string, number>
}

export declare class RustPseudoTerminal {
Expand Down
Loading