fix(js): keep refs to ignored files and allow opting out of pruning stale refs in typescript sync generator #27636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 48e9099. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
leosvelperez
requested review from
JamesHenry and
FrozenPandaz
and removed request for
mandarini
leosvelperez
force-pushed
the
js/ts-sync-external-refs
branch
from
d5290f8 to
285239e
Compare
JamesHenry
reviewed
Sep 10, 2024
packages/js/src/generators/typescript-sync/typescript-sync.spec.ts
Outdated
Show resolved
Hide resolved
JamesHenry
reviewed
Sep 10, 2024
packages/js/src/generators/typescript-sync/typescript-sync.spec.ts
Outdated
Show resolved
Hide resolved
JamesHenry
requested changes
Sep 10, 2024
… typescript sync generator
… name and comments
leosvelperez
force-pushed
the
js/ts-sync-external-refs
branch
from
285239e to
48e9099
Compare
FrozenPandaz
approved these changes
Sep 10, 2024
JamesHenry
approved these changes
Sep 10, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When the
@nx/js:typescript-syncgenerator updates a tsconfig file of an Nx project, it prunes project references pointing to a path that's not part of the Nx project files (including paths inside a nested project) if they don't belong to a project that is a dependency.Expected Behavior
When the
@nx/js:typescript-syncgenerator updates a tsconfig file of an Nx project, it should only prune project references pointing to a path that's not part of the Nx project files if it's not ignored and not part of a dependency.Additionally, a new
nx.sync.ignoredReferencestop-level option in tsconfig files allows specifying custom project references that the@nx/js:typescript-syncsync generator should ignore and not prune.Related Issue(s)
Fixes #