Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nxls): repair generatorOptions request in node 22 #2407

Merged
merged 3 commits into from
Feb 18, 2025
Merged

fix(nxls): repair generatorOptions request in node 22 #2407

merged 3 commits into from
Feb 18, 2025

Conversation

MaxKless
Copy link
Collaborator

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b06c327.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e-ci,ty... ✅ Succeeded 3m 27s View ↗
nx-cloud record -- yarn nx-cloud conformance:check ✅ Succeeded 4s View ↗
nx-cloud record -- yarn nx sync:check ✅ Succeeded 6s View ↗
nx-cloud record -- ./gradlew ktfmtCheck ✅ Succeeded 4s View ↗
nx-cloud record -- ./gradlew projectReportAll ✅ Succeeded 29s View ↗
nx affected --targets=build,test,e2e-ci --confi... ✅ Succeeded 11m 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-18 15:46:25 UTC

Coly010
Coly010 approved these changes Feb 18, 2025
View reviewed changes
.github/workflows/ci_checks.yml
@@ -6,7 +6,7 @@ on:
pull_request:

env:
NODE_VERSION: 20
NODE_VERSION: 22
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider a matrix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should, yea....

@MaxKless MaxKless linked an issue Feb 18, 2025 that may be closed by this pull request
WebStorm: 'No options' displayed when using generators #2392
Closed
@MaxKless MaxKless merged commit b259610 into master Feb 18, 2025
9 checks passed
@MaxKless MaxKless deleted the fix-no-options branch February 18, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coly010 Coly010 Coly010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebStorm: 'No options' displayed when using generators
2 participants
@MaxKless @Coly010