Skip to content

Commit

Permalink
feat: optional path delimiter
Browse files Browse the repository at this point in the history
Fixes #17
  • Loading branch information
Balte de Wit committed Dec 23, 2020
1 parent 25109ca commit b7bf058
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions src/Ember/Client/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,11 @@ export class EmberClient extends EventEmitter {
}
}
}
async getElementByPath(path: string, cb?: (EmberNode: TreeElement<EmberElement>) => void) {
async getElementByPath(
path: string,
cb?: (EmberNode: TreeElement<EmberElement>) => void,
delimiter = '.'
) {
const getNext = (elements: Collection<NumberedTreeNode<EmberElement>>, i?: string) =>
Object.values(elements || {}).find(
(r) =>
Expand All @@ -356,7 +360,7 @@ export class EmberClient extends EventEmitter {
node.children && getNext(node.children, i)

const numberedPath: Array<number> = []
const pathArr = path.split('.')
const pathArr = path.split(delimiter)
const i = pathArr.shift()
let tree: NumberedTreeNode<EmberElement> | undefined = getNext(this.tree, i)
if (tree?.number) numberedPath.push(tree?.number)
Expand Down Expand Up @@ -419,7 +423,9 @@ export class EmberClient extends EventEmitter {
}

private async _sendRequest<T>(node: RootElement, hasResponse = true): RequestPromise<T> {
const reqId = Math.random().toString(24).substr(-4)
const reqId = Math.random()
.toString(24)
.substr(-4)
const requestPromise: RequestPromiseArguments<T> = {
reqId,
sentOk: false
Expand Down

0 comments on commit b7bf058

Please sign in to comment.