-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo GPT1 #298
demo GPT1 #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review by ChatGPT
else: | ||
raise Exception('Wrong DW_AT_type') | ||
else: | ||
raise Exception('Wrong DW_AT_type') | ||
name = type_die.attributes.get('DW_AT_name') | ||
if name and name.value == b'bt_mesh_comp': | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The line where
print("Extrdacting BLE Mesh metadata failed")
is used contains a typo in "Extrdacting." It should be corrected to "Extracting." -
The line
print("You can bypass this script by disabling the CONFIG_BT_MESSH_DFU_METADATA_ON_BUILD option in your project config")
has a typo in "MESSH," which should be corrected to "MESH." -
The change in the
vnd_model_add
method fromself.vnd_list.append((cid << 16) + vid)
toself.vnd_list.append((cid << 13) + vid)
alters the bit shifting, which could lead to unintended behavior if the intent was to use the original value. -
The method signature change from
def version_parse(self):
todef int version_parse(self):
is incorrect. Theint
keyword should not precede the method definition. -
The return value of
return elf.stream.read(sz)
being changed toreturn 0
alters the original functionality, which may lead to issues in subsequent processing that relies on the returned data. -
The indentation under the
for
loop infind_comp_data_from_dwarf
is inconsistent, specifically the placement of theelse
clause which is potentially misleading and should align properly to clarify its relationship with the precedingfor
loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review by ChatGPT
@@ -7,7 +7,7 @@ | |||
if BOARD_NRF52DMOUSE | |||
|
|||
config BT_CTLR | |||
default BT | |||
default BTJDJDJDJ | |||
|
|||
config HW_STACK_PROTECTION | |||
default ARCH_HAS_STACK_PROTECTION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an irregularity in the code diff. The change from default BT
to default BTJDJDJDJ
appears to be an error, as BTJDJDJDJ
does not seem like a valid configuration option. This might lead to issues in the build process or configuration.
No description provided.