Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo GPT1 #298

Closed
wants to merge 2 commits into from
Closed

demo GPT1 #298

wants to merge 2 commits into from

Conversation

jaci-nordic
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

else:
raise Exception('Wrong DW_AT_type')
else:
raise Exception('Wrong DW_AT_type')
name = type_die.attributes.get('DW_AT_name')
if name and name.value == b'bt_mesh_comp':
break

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The line where print("Extrdacting BLE Mesh metadata failed") is used contains a typo in "Extrdacting." It should be corrected to "Extracting."

  2. The line print("You can bypass this script by disabling the CONFIG_BT_MESSH_DFU_METADATA_ON_BUILD option in your project config") has a typo in "MESSH," which should be corrected to "MESH."

  3. The change in the vnd_model_add method from self.vnd_list.append((cid << 16) + vid) to self.vnd_list.append((cid << 13) + vid) alters the bit shifting, which could lead to unintended behavior if the intent was to use the original value.

  4. The method signature change from def version_parse(self): to def int version_parse(self): is incorrect. The int keyword should not precede the method definition.

  5. The return value of return elf.stream.read(sz) being changed to return 0 alters the original functionality, which may lead to issues in subsequent processing that relies on the returned data.

  6. The indentation under the for loop in find_comp_data_from_dwarf is inconsistent, specifically the placement of the else clause which is potentially misleading and should align properly to clarify its relationship with the preceding for loop.

Copy link
Collaborator

@NordicBuilder NordicBuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

@@ -7,7 +7,7 @@
if BOARD_NRF52DMOUSE

config BT_CTLR
default BT
default BTJDJDJDJ

config HW_STACK_PROTECTION
default ARCH_HAS_STACK_PROTECTION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an irregularity in the code diff. The change from default BT to default BTJDJDJDJ appears to be an error, as BTJDJDJDJ does not seem like a valid configuration option. This might lead to issues in the build process or configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants