Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve location detection / save #48

Closed
2 tasks done
bagage opened this issue Jul 17, 2016 · 2 comments
Closed
2 tasks done

Improve location detection / save #48

bagage opened this issue Jul 17, 2016 · 2 comments
Milestone

Comments

@bagage
Copy link
Collaborator

bagage commented Jul 17, 2016

Currently when one opens http://brouter.de/brouter-web, he always get map centered on Frankfurt with zoom level 8 or so, the first thing to do is to move the map over his own position.
It could be great to save the last used position so that when you always bike in the same area, you do not need to re-localize yourself again. I know that permalink can solve this issue, but I'd like to know if a cookie could be saved to store position for default position (like openstreetmap.org does for instance, but also google maps)?
I'd be glad to make a PR for this if you think it's worth it!

edit: a "localize me" button could be nice too, see this demo.

@nrenner
Copy link
Owner

nrenner commented Jul 19, 2016

It seems like there is a plugin Leaflet.RestoreView for keeping the last map position.

Should be straightforward to add, I can do that, not really a need for a PR. But generally, contributions are welcome!

Using the leaflet-locatecontrol you linked is already on my to-do list together with some basic mobile support.

@nrenner nrenner added this to the 0.6.0 milestone Jul 19, 2016
bagage added a commit to bagage/brouter-web that referenced this issue Jul 20, 2016
@bagage bagage changed the title Save map position for next use? Improve location detection / save Jul 20, 2016
@bagage
Copy link
Collaborator Author

bagage commented Jul 20, 2016

So this issue could be split up in two tasks:

Basic mobile support would be awesome indeed when you must check routes while traveling 😃. Looking forward for it too!

edit: added todos in first post to have them displayed on issues page as well.

bagage added a commit to bagage/brouter-web that referenced this issue Jul 21, 2016
bagage added a commit to bagage/brouter-web that referenced this issue Jul 21, 2016
@bagage bagage closed this as completed Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants