Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle drawing mode (disable/enable) via panel button not keyboard button #41

Closed
KarlaF90 opened this issue Jan 4, 2016 · 5 comments
Closed
Milestone

Comments

@KarlaF90
Copy link

KarlaF90 commented Jan 4, 2016

Hi,

I love BRouter and I love its web interface!! As it is very helpful to use it via smartphone it would be really great to be able to toggle between disabled and enabled drawing mode via a small hitbox in the panel. As you cannot use the hotkeys 'q' and 'd' on the touchscreen this is really beneficial. This would make BRouter Web usable on Android and iPhone.

Together with issue #40 (toggle information panels) or with a resizeable panel BRouter Webs usability on smartphones would significantly increase.

Thank you for your nice service 👍

@nrenner
Copy link
Owner

nrenner commented Jan 7, 2016

Thanks. Already thought that having a button to toggle the drawing mode would be useful. Also see my comment to #40.

@KarlaF90
Copy link
Author

Lieber Norbert, 
Meinst Du, dass es für das Brouter web Interface noch zu Beginn der RadSaison das Toggle Tooltip Feature geben wird? Dann könnte man das extrem gute Brouter auch mit dem Iphone benutzen. Das wäre mega praktisch. 
Beste Grüße, 
Karla

-------- Ursprüngliche Nachricht --------
Von: Norbert Renner [email protected]
Datum: 07.01.2016 19:46 (GMT+01:00)
An: nrenner/brouter-web [email protected]
Cc: KarlaF90 [email protected]
Betreff: Re: [brouter-web] toggle drawing mode (disable/enable) via panel
button not keyboard button (#41)

Thanks. Already thought that having a button to toggle the drawing mode would be useful. Also see my comment to #40.


Reply to this email directly or view it on GitHub.

@bagage
Copy link
Collaborator

bagage commented Jul 25, 2016

Hello @nrenner,
I am quite interested in mobile support and I guess this issue is the easiest to solve following my #49 PR, so if noone is working on it I might suggest a PR for it? Let me know ;-).

@nrenner
Copy link
Owner

nrenner commented Jul 26, 2016

Sure, go ahead. I started looking into mobile support, but this is independent.

See the delete route button using the EasyButton plugin as an example. You should be able to call routing.draw([true|false]).

bagage added a commit to bagage/brouter-web that referenced this issue Jul 28, 2016
bagage added a commit to bagage/brouter-web that referenced this issue Jul 28, 2016
nrenner added a commit that referenced this issue Jul 28, 2016
Toggle drawing mode via panel button (#41)
@nrenner nrenner added this to the 0.6.0 milestone Jul 28, 2016
@nrenner
Copy link
Owner

nrenner commented Jul 28, 2016

Implemented by @bagage with #50.

@nrenner nrenner closed this as completed Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants