Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic mobile support #34

Closed
nrenner opened this issue Oct 2, 2015 · 10 comments
Closed

Basic mobile support #34

nrenner opened this issue Oct 2, 2015 · 10 comments
Milestone

Comments

@nrenner
Copy link
Owner

nrenner commented Oct 2, 2015

Touch support for controls (stopPropagation for touch events?), see reported issues:

brouter web: Pulldown menu do not work

  • Profile and Alternative option lists not selectable

Is there any internet browser for android devices which works with http://brouter.de/brouter-web/ (altitude profile, 4 possibilities, GPX download)?

  • not able to insert (copy and paste) Profile code
  • not able to click/touch on GPX download
@nrenner nrenner added this to the 0.6.0 milestone Oct 2, 2015
@bagage
Copy link
Collaborator

bagage commented Jul 31, 2016

I know that you did some work regarding this issue @nrenner (and maybe #35), can you share the current status please? I'd again gladly help to make it (and #35 too) happens!

@nrenner
Copy link
Owner Author

nrenner commented Aug 1, 2016

Was going to ask and share what I have. I would be happy if you would take over the mobile support!

Actually, there isn't much yet, just some first experiments, see the mobile-test branch. I also have some notes, I will clean these up and make a wiki page tomorrow.

What are your ideas? What would be your approach?

@nrenner
Copy link
Owner Author

nrenner commented Aug 2, 2016

@bagage See wiki pages Mobile and Mobile code snippets. So I guess that's all I have right now.

@bagage
Copy link
Collaborator

bagage commented Aug 2, 2016

Thanks, awesome! Your wiki seems complete enough of existing issues; I have yet no solution as a developer, but I'll dig into some code & your references & other responsive design maps to be inspired from.
I'll update you when I have more precise ideas.

@RoPP
Copy link
Contributor

RoPP commented Aug 9, 2016

Here attempt to make BRouter-web a little bit more mobile friendly.
This is still a WIP branch and there is still some missing features but it should be enough to test and see if it is the way to go.

screen shot 2016-08-09 at 11 49 05

@nrenner
Copy link
Owner Author

nrenner commented Aug 11, 2016

Wow, that's already a working mobile version!

Some thoughts:

  • Profile name: consider long names e.g. 'vm-forum-velomobil-schnell'
  • Elevation graph: What was the reason for having our own implementation? What are your plans for that?
  • Options: while this is Ok for mobile, on the desktop I would still like being able to switch through profiles/alternatives (e.g. up/down keys) and see the result without a modal blocking the screen.
  • No left pane / sidebar: not really needed for mobile, but I think we can't do without on desktop, esp. for data tab (missing?) and future turn instructions list display turn instructions #42 and tag graph Display statistics of street surface #45, that all should be next to the map and synchronize highlight on hover.

@bagage
Copy link
Collaborator

bagage commented Sep 6, 2016

I will continue the work started by @RoPP, but here are some replies:

  • long names won't fit on small screens, maybe we should avoid having too long names? In my opinion this is not a very important information anyway once you selected it.
  • i'll fix up/down shortcuts on desktop.
  • data tab should indeed be readded on desktop. Considering display turn instructions #42 and Display statistics of street surface #45 let's see when they happen!

In the mean time is there any ETA for next release (to use #49 and #50 as soon as possible)? Thanks.

@poutnikl
Copy link

poutnikl commented Sep 6, 2016

Longnames can be used quite often, referring to values of various flags or tunables.
Especially with my profile generator.
See e.g. "Car-FastEco-TollFree-SecondaryRoads.brf"

@nrenner
Copy link
Owner Author

nrenner commented Sep 7, 2016

  • long names won't fit on small screens, maybe we should avoid having too long names? In my opinion this is not a very important information anyway once you selected it.

Not sure about avoiding long names, maybe switching to an alternative short name or shorten display with "..." in the middle on small screens. But agree that as a simple solution we can also just not show it.

  • i'll fix up/down shortcuts on desktop.

One idea would be to directly integrate the two dropdowns into the top bar.

Forgot to mention the Itinerary control that is shown as tab in the transit demo (see config.js).

Generally, the mobile version already looks great, just a bit too focused on mobile for my taste right now. I don't insist on keeping the current left pane, some other collapsible Sidebar will also do for the data table and for editing the profile.

My original motivation for brouter-web was to build some kind of IDE for profile development and a planning tool with a focus on desktop. So mobile support would be great, it just shouldn't affect the desktop experience too much, e.g. by requiring more clicks than before or slowing down feedback loops.

@nrenner
Copy link
Owner Author

nrenner commented Sep 7, 2016

In the mean time is there any ETA for next release (to use #49 and #50 as soon as possible)? Thanks.

Well, the plan was to have version 0.6.0 ready for the start of the bike season - so much for ETAs. Already was thinking about splitting the milestone, but still wanted to look for icon set alternatives and do some other minor stuff.

But now that we have exceeded the Bing usage limit, I really should add a replacement and get some release out soon.

@nrenner nrenner modified the milestones: 0.7.0, 0.6.0 Oct 12, 2016
bagage added a commit to bagage/brouter-web that referenced this issue Nov 26, 2016
bagage added a commit to bagage/brouter-web that referenced this issue Nov 27, 2016
bagage added a commit to bagage/brouter-web that referenced this issue Nov 30, 2016
bagage added a commit to bagage/brouter-web that referenced this issue Jan 11, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 12, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 15, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 16, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 16, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 16, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 16, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 16, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 16, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 16, 2017
bagage added a commit to bagage/brouter-web that referenced this issue Jan 18, 2017
nrenner added a commit that referenced this issue Jan 23, 2017
Updating UI to also fit on mobile devices. Fix #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants