-
Notifications
You must be signed in to change notification settings - Fork 77
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Restore not adding custom profile to URL (#66)
See 1527a07
- Loading branch information
Showing
1 changed file
with
5 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa86f0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really unfortunate
I used this as a way to advertise what brouter could do
Every time someone asked about something specific, I would send them a profile that tried to do it, and deletion was not a problem because they would click the link soon enough
Could you think about restoring the old behaviour maybe?
Or maybe outsource it into a "permalink" buttom, that spawns a warning it will only work for a limited time?
fa86f0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this, I suppose that restriction was removed by accident in #74. This was never a supported or announced feature and has not been live on brouter.de.
That custom profiles are deleted only after some time is an implementation detail that can change at any time and should not be exposed to the user.
The plan is that the user can make profiles permanent and I was going to work on that next, but then #145 has come up.