deps: replace builtins dependency with Node.js module.builtinModules
#104
Conversation
|
wraithgar
changed the title
builtins dependency with Node.js module.builtinModulesbuiltins dependency with Node.js module.builtinModules
🤖 I have created a release *beep* *boop* --- ## [5.0.1](v5.0.0...v5.0.1) (2024-05-06) ### Dependencies * [`f12f849`](f12f849) [#104](#104) replace `builtins` dependency with Node.js `module.builtinModules` (#104) ### Chores * [`f2b3233`](f2b3233) [#112](#112) auto publish (#112) (@lukekarrys) * [`406b31a`](406b31a) [#110](#110) bump @npmcli/template-oss to 4.22.0 (@lukekarrys) * [`bcc451a`](bcc451a) [#69](#69) update tap coverage in package.json (#69) (@wraithgar) * [`320e5dd`](320e5dd) [#68](#68) add new tests to reach full test coverage (#68) (@janbritz) * [`5c72411`](5c72411) [#59](#59) bump @npmcli/eslint-config from 3.1.0 to 4.0.0 (@dependabot[bot]) * [`a893e39`](a893e39) [#110](#110) postinstall for dependabot template-oss PR (@lukekarrys) * [`13f9b85`](13f9b85) [#109](#109) bump @npmcli/template-oss from 4.21.3 to 4.21.4 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
It appears that this PR introduces a breaking change in functionality. In version 5.0.0, the builtins package was employed to identify built-in package names. This package is environment-agnostic and seamlessly operates within browser environments. However, starting with version 5.0.1, the implementation shifted to leveraging Node.js's internal module to perform this detection. This change inherently disrupts compatibility in browser contexts. Projects upgrading to version 5.0.1 may encounter issues, even though build tools such as Webpack might offer superficial polyfills for these packages. Notably, the invocation of the includes method on builtins leads to errors, diverging from its intended behavior and inadvertently breaking functionality. I recommend revisiting this implementation to ensure cross-environment compatibility and preserving the non-breaking nature of updates. |
This PR replaces the
builtinsdependency with the Node.js internalmodule.builtinModulesproperty/constant. This change does not break any functionality of this package.I am aware of this comment in the CONTRIBUTING.md file:
In my defense, this PR does not add a third-party dependency but removes one so I think it should be considered.
References