fix: dont create chore only PRs #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/chore-only-changelog
branch
from
ab40d5d to
e92f7d2
Compare
|
One thing I need to test is what will happen to open PRs that contain only chores if the PR after this lands. If it doesn't close those PRs then we will need to close all release PRs (via stafftools) and then land the template-oss update everywhere. This will have the effect of only opening non-chore releases. |
wraithgar
approved these changes
Apr 22, 2024
Merged
lukekarrys
pushed a commit
that referenced
this pull request
May 3, 2024
🤖 I have created a release *beep* *boop* --- ## [4.22.0](v4.21.4...v4.22.0) (2024-05-03) ### Features * [`21c9262`](21c9262) [#440](#440) use macos-(latest|13) based on node version (#440) (@lukekarrys) ### Bug Fixes * [`8b2e738`](8b2e738) [#432](#432) remove custom node-workspace plugin (@lukekarrys) * [`0df268d`](0df268d) [#442](#442) properly check for diff with multiple files from overwrite:false (#442) (@lukekarrys) * [`2eca24b`](2eca24b) [#441](#441) use git+https protocol for repo url (#441) (@lukekarrys) * [`732dddc`](732dddc) [#439](#439) update actions workflow versions (#439) (@lukekarrys) * [`7949ec3`](7949ec3) [#438](#438) add node 22 to CI matrix (#438) (@lukekarrys) * [`6d54cbf`](6d54cbf) [#436](#436) get correct exit code from npm publish/view (#436) (@lukekarrys) * [`d0bf7c2`](d0bf7c2) [#435](#435) update license (#435) (@lukekarrys) * [`df03d8b`](df03d8b) [#433](#433) dont create chore only PRs (#433) (@lukekarrys) ### Dependencies * [`dff1b5b`](dff1b5b) [#432](#432) bump release-please from 16.3.1 to 16.10.2 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jun 20, 2024
This was referenced Aug 7, 2024
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #378 we decided to make template-oss rebuild PRs for chore commits to solve the problem of needing to manually recreate PRs after pushing a chore that affected the release process.
This was a good change but had the side effects of:
Choressections of the changelog for repos that don't get released often but landed a lot of template-oss updates between releases. This was greatly reduced in fix: only use latest template-oss specific commits in changelog #430As a side effect of this I removed the code that was responsible for collapsing the chores section. The goal was to reduce noise in the changelog but was never turned on because it didn't work right. I think the above two items reduce noise enough that we don't need to collapse the chores section anymore.