Use --force when installing deps for git prepare scripts #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a git dependency has conflicting peerDependencies, dependencies with engines fields that don't match the current environment, and so on, it isn't much help to crash the installation for these issues. The user installing the git dependency is likely not in a position to fix them, but from npm and Arborist's points of view, it is the 'main' project that has a problem (since the install is being run as a separate process). This commit passes '--force' to the npm child process that installs dependencies for git packages before running their 'prepare' script, to ignore all such issues (or reduce them to warnings). Related to: npm/cli#2548 PR-URL: #63 Credit: @isaacs Close: #63 Reviewed-by: @nlf
nlf
approved these changes
Feb 1, 2021
isaacs
force-pushed
the
isaacs/force-install-for-git-dep-preparation
branch
from
505becb to
0d0d76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a git dependency has conflicting peerDependencies, dependencies with
engines fields that don't match the current environment, and so on, it
isn't much help to crash the installation for these issues. The user
installing the git dependency is likely not in a position to fix them,
but from npm and Arborist's points of view, it is the 'main' project
that has a problem (since the install is being run as a separate
process).
This commit passes '--force' to the npm child process that installs
dependencies for git packages before running their 'prepare' script, to
ignore all such issues (or reduce them to warnings).
Related to: npm/cli#2548
References