Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

fix(stdio): correct log #8

Closed
wants to merge 1 commit into from
Closed

fix(stdio): correct log #8

wants to merge 1 commit into from

Conversation

nadongguri
Copy link

This warning log should be corrected.

opts.log.warn('lifecycle', logid(pkg, stage), 'cannot run in wd',
  '%s %s (wd=%s)', pkg._id, pkg.scripts[stage], wd
)

[example]
npm WARN lifecycle undefined~install: cannot run in wd %s %s (wd=%s) undefined echo > .last_update /root/github/upstream/bacardi

[changed]
npm WARN lifecycle undefined~install: cannot run in wd undefined echo > .last_update (wd= /root/github/upstream/bacardi )

@zkat
Copy link
Contributor

zkat commented Mar 7, 2018

superseded by #12

@zkat zkat closed this Mar 7, 2018
@nadongguri nadongguri deleted the minor_issue branch March 8, 2018 04:03
@nadongguri
Copy link
Author

nadongguri commented Mar 8, 2018

Hi, Even if it's a trivial patch and it might not be better than another patch, I've been waiting for your feedback so far.
I'd like to know why my comment is deleted and if there was something that I missed in this pr based on your Contributor Guide. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants