fix: disallow child going against parent ignore

npm · Nov 24, 2023 · a642e24 · a642e24
1 parent 12a7c00
commit a642e24
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -219,6 +219,10 @@ class Walker extends EE {
       included = this.parent.filterEntry(pt, partial)
     }
 
+    if (!included) {
+      return false
+    }
+
     this.ignoreFiles.forEach(f => {
       if (this.ignoreRules[f]) {
         this.ignoreRules[f].forEach(rule => {

diff --git a/test/nested-ignores.js b/test/nested-ignores.js
@@ -7,7 +7,8 @@ const path = resolve(__dirname, 'fixtures')
 // set the ignores just for this test
 var c = require('./common.js')
 c.ignores({
-  '.ignore': ['*', 'd', 'h', '!d/c/h/.dch', '!/h/c/d/hcd'],
+  '.ignore': ['*', '!c', 'd', 'h', '!d/c/h/.dch', '!/h/c/d/hcd'],
+  'c/.ignore': ['*'], // ignore everything
   'd/.ignore': ['!*', '.ignore'], // unignore everything
   'd/d/.ignore': ['*'], // re-ignore everything
   'd/c/.ignore': ['*', '!/h/.dch'], // original unignore
@@ -18,9 +19,6 @@ c.ignores({
 // the only files we expect to see
 var expected = [
   'd/c/h/.dch',
-  'h/c/d/.hcd',
-  'h/c/d/dch',
-  'h/c/d/ddd',
   'h/c/d/hcd',
 ]