actually depend on graceful-fs #7
Conversation
Since graceful-fs doesn't monkey-patch the builtin, there's no need to make it optional. Also, it's currently being pulled in all the time anyway, so why not just depend on it normally?
|
We'll have to remove [email protected] from the .travis.yml file, but this seems cleaner and simpler than #9 to me. P.S. I've added @isaacs and @othiym23 as collaborators on this repo in case I fail to respond to things quickly enough. Also, I don't really know enough to know whether #4 should be merged or not. |
|
Does graceful-fs not work on v0.8? |
|
Oh, ffs, ok, make it |
|
Yes, that might be sufficient |
|
Expanded the graceful-fs dep version range, so it should work wiht v0.8 now. |
|
That looks like it should be fine, but the travis-ci build is failing for 0.8? |
|
OMG. npm 1.2 is so ancient and buggy and terrible. @tjfontaine Please accept nodejs/node-v0.x-archive#7797 this is a huge waste of time for all of us. @ForbesLindesay updated, should work now. Let's wait for travis to complete. |
|
Travis completed successfully. +1. |
actually depend on graceful-fs
|
Released as 2.0.1 |
Since graceful-fs doesn't monkey-patch the builtin, there's no need to make
it optional. Also, it's currently being pulled in all the time anyway, so why
not just depend on it normally?