fix: restore exit code on "npm outdated" #3799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
npm-outdated-exit-code
branch
from
0e03826 to
c9cb522
Compare
gfyoung
changed the title
|
Smoke test will have to be fixed for this. |
wraithgar
reviewed
Sep 27, 2021
* More compact exitCode check * Update smoke-test to check exit code
|
@wraithgar: I've pushed a new commit to address the feedback. Smoke tests should be passing now. |
wraithgar
reviewed
Sep 27, 2021
wraithgar
approved these changes
Sep 27, 2021
|
Not sure why this PR isn't showing as merged. It's in |
|
This will go out w/ Thursday's release. Thank you for submitting this fix! |
This was referenced Oct 7, 2021
|
This change is wrong. Exit code 1 means the program had an error. Correctly listing outdated packages is not an error and must not return exit code 1. https://en.wikipedia.org/wiki/Exit_status "For the shell's purposes, a command which exits with a zero exit status has succeeded. A nonzero exit status indicates failure. " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2556
ref: #1750
The xref'ed PR apparently dropped this behavior without any explanation.
release-latestif appropriate.exitCodeandlogsare somewhat related in terms of the expected results. I copy-pasted theexitCodecheck everywhere for the time being.