Skip to content

Commit

Permalink
use hbs template
Browse files Browse the repository at this point in the history
  • Loading branch information
reggi committed Jan 28, 2025
1 parent 4ab57e5 commit e35c62b
Show file tree
Hide file tree
Showing 2 changed files with 62 additions and 41 deletions.
37 changes: 18 additions & 19 deletions .github/workflows/ci-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,13 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
conclusion: ${{ job.status }}
check_id: ${{ steps.create-check.outputs.check-id }}

smoke-tests:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Tests - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
Expand All @@ -160,10 +160,9 @@ jobs:
os: ubuntu-latest
shell: bash
node-version:
- 18.17.0
- 18.x
- 20.5.0
- 20.17.0
- 20.x
- 22.9.0
- 22.x
runs-on: ${{ matrix.platform.os }}
defaults:
Expand All @@ -183,7 +182,7 @@ jobs:
if: ${{ inputs.check-sha }}
uses: ./.github/actions/create-check
with:
name: "Publish dry-run - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
name: "Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ inputs.check-sha }}
- name: Setup Node
Expand All @@ -197,7 +196,7 @@ jobs:
run: node scripts/git-dirty.js
- name: Reset Deps
run: node scripts/resetdeps.js
- name: Smoke Publish
- name: Smoke Tests
run: ./scripts/smoke-tests.sh
- name: Conclude Check
uses: LouisBrunner/[email protected]
Expand All @@ -206,13 +205,13 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
conclusion: ${{ job.status }}
check_id: ${{ steps.create-check.outputs.check-id }}

publish-dryrun:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Publish dry-run - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
name: Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
Expand Down Expand Up @@ -244,7 +243,7 @@ jobs:
if: ${{ inputs.check-sha }}
uses: ./.github/actions/create-check
with:
name: "Publish dry-run - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
name: "Smoke Publish - ${{ matrix.platform.name }} - ${{ matrix.node-version }}"
token: ${{ secrets.GITHUB_TOKEN }}
sha: ${{ inputs.check-sha }}
- name: Setup Node
Expand All @@ -258,7 +257,7 @@ jobs:
run: node scripts/git-dirty.js
- name: Reset Deps
run: node scripts/resetdeps.js
- name: Smoke Publish
- name: Publish Dry-Run
run: ./scripts/publish-dryrun.sh
- name: Conclude Check
uses: LouisBrunner/[email protected]
Expand Down
66 changes: 44 additions & 22 deletions scripts/template-oss/ci-release-yml.hbs
Original file line number Diff line number Diff line change
@@ -1,23 +1,45 @@
{{> ciReleaseYml }}
{{> ciReleaseYml }}

smoke-publish:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
windowsCI=false
macCI=false
}}
- name: Smoke Publish
run: ./scripts/smoke-publish-test.sh
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: steps.create-check.outputs.check-id && always()
with:
token: $\{{ secrets.GITHUB_TOKEN }}
conclusion: $\{{ job.status }}
check_id: $\{{ steps.create-check.outputs.check-id }}
smoke-tests:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
windowsCI=false
macCI=false
}}
- name: Smoke Tests
run: ./scripts/smoke-tests.sh
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: steps.create-check.outputs.check-id && always()
with:
token: $\{{ secrets.GITHUB_TOKEN }}
conclusion: $\{{ job.status }}
check_id: $\{{ steps.create-check.outputs.check-id }}

publish-dryrun:
# This cant be tested on Windows because our node_modules directory
# checks in symlinks which are not supported there. This should be
# fixed somehow, because this means some forms of local development
# are likely broken on Windows as well.
{{> jobMatrixYml
jobName="Smoke Publish"
jobCheckout=(obj ref="${{ inputs.ref }}")
jobCreateCheck=(obj sha="${{ inputs.check-sha }}")
windowsCI=false
macCI=false
}}
- name: Publish Dry-Run
run: ./scripts/publish-dryrun.sh
- name: Conclude Check
uses: LouisBrunner/[email protected]
if: steps.create-check.outputs.check-id && always()
with:
token: $\{{ secrets.GITHUB_TOKEN }}
conclusion: $\{{ job.status }}
check_id: $\{{ steps.create-check.outputs.check-id }}

0 comments on commit e35c62b

Please sign in to comment.