This repository was archived by the owner on Jan 20, 2022. It is now read-only.
lint tests dry tree printing #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/lint-tests-dry-tree-printing
branch
3 times, most recently
from
e014f72 to
aa6f437
Compare
This gets rid of all the custom tree-printing and duplicative path normalization done in all tests, and adds the tests to the set of files to be linted.
isaacs
force-pushed
the
isaacs/lint-tests-dry-tree-printing
branch
from
aa6f437 to
977c9e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only should be one way to print trees. Get rid of duplication in the tests, and in the scripts.
Based on #214, land that first.