Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delayed commit in exporter #5530

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

NinoFloris
Copy link
Member

As the api model doesn't allow for it when there are zero-sized columns (see code comment)

Fixes #5522

Fixes #5522
As the api model doesn't allow for it when there are zero-sized columns
@vonzshik
Copy link
Contributor

Maybe also add a test?

@NinoFloris NinoFloris merged commit 17f0926 into main Jan 17, 2024
17 checks passed
@NinoFloris NinoFloris deleted the fix-zero-size-exporter-case branch January 17, 2024 20:26
NinoFloris added a commit that referenced this pull request Jan 17, 2024
* Remove delayed commit in exporter

Fixes #5522
As the api model doesn't allow for it when there are zero-sized columns

* Add test

(cherry picked from commit 17f0926)
@NinoFloris
Copy link
Member Author

Backported to 8.0.2 via 43fcf6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary export cannot read empty string
2 participants