-
Notifications
You must be signed in to change notification settings - Fork 27
Updated KtLintConfigurator to check for new report file name for #201. #202
Updated KtLintConfigurator to check for new report file name for #201. #202
Conversation
Can one of the admins review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. 🎉 Thanks for fixing this. I only have small suggestions. Let me know what you think and I will merge.
plugin/src/main/groovy/com/novoda/staticanalysis/internal/ktlint/KtlintConfigurator.groovy
Outdated
Show resolved
Hide resolved
plugin/src/test/groovy/com/novoda/staticanalysis/internal/ktlint/KtlintIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
@hal9002 ok to test |
ok to test |
Here goes my failed attempts to trigger CI checks. @mr-archano can you help? |
@tasomaniac I've made your suggested changes. I've also noticed that my git history looks a little weird, and I think that's because on my fork I rebased off of master and not develop. Let me know if you want me to correct this & rebase off of develop, and I can do that once we've reviewed these changes. |
Also @AdamMc331, can you rebase into develop and only keep your commit(s)? The default branch is |
…e method. Also updated the ktlint configurate to retrieve the outputFileMap from a separate method.
d8399ba
to
c41b42b
Compare
All set! I didn't squash mine but let me know if that's preferred and I can do this again. 🙈 |
CI is running. Fingers crossed 🤞 As we tried #197 before, we had memory issues. Now i'm also trying here #203. With #203, I did some optimizations on tests to consume less memory. If that goes well, we can merge both and do a release. Btw, with this change, our Gradle requirement does not change. Since we don't have hard-dependency to ktlint, we will still be supporting Gradle 4.10 and above. |
@tasomaniac Are these the same memory related issues you've seen before? |
Yep. Finally had success in #203. Now I need a review/approval. Will ping @mr-archano for that and we can release this soon. |
Great, once that is resolved just ping me and I will rebase this again. |
Thanks to @Mecharyry it is actually done. Merging once CI is good. |
Test this please oh mighty CI, destroyer of dreams |
@tasomaniac Looks like we're all good! Thanks so much for your review and help on this. :) |
Thank you for the contribution. 🙌 Prepared PR for releasing version 1.1 #206 |
Currently this plugin won't support version 9.0.0+ from the ktlint-gradle plugin: #201
This PR resolves it by:
Version 5.6.2 might be a larger jump than necessary, but I wasn't sure how to determine what a good change was. For ktlint-gradle the minimum supported version is
5.4.1
, so let me know if we should use that instead.Validated by updating to 9.0.0 in the sample app and ensuring that runs, as well as running all of the tests locally.