This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Docs/Update custom evaluator sample #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
previously approved these changes
May 30, 2019
docs/incubating/custom-evaluator.md
Outdated
| ```gradle | ||
| evaluator { Set allViolations -> | ||
| allViolations.each { violation -> | ||
| if (violation.name == "PMD" && (violation.errors > 5)) { |
There was a problem hiding this comment.
Below it says toolName but here it is name. Which one it is? 🤔
There was a problem hiding this comment.
Good point! The backing property is called toolName but the method to access it is getName (and I'm guessing that's why the compiler allows .name as accessor?)
Do you think we shall stick to just name in the sample to create less confusion?
There was a problem hiding this comment.
Looks like toolName is private. We shouldn't really mention that since it is not usable. Sticking to name makes sense 👍
There was a problem hiding this comment.
amended here d3da57b
tasomaniac
approved these changes
May 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Violationssource code