This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Lazy Task Configuration for ktlint #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to drop support for ktlint 6.1.0 Also 7.0.0 is failing on Ktlint side now only on Kotlin only projects
|
Failed because Daemon disappeared unexpectedly. This happens when CI is busy/loaded. Will retry later |
|
@hal9002 retest this please |
1 similar comment
|
@hal9002 retest this please |
|
All green 👍 |
mr-archano
approved these changes
May 18, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR of the series where I enable lazy task configuration. Fixes #161
We had somewhat complex (but well tested) setup for ktlint where we support multiple versions even-though there were breaking changes in between. To be able to do this, I used
matchingto dynamically load all Ktlint tasks and pick the ones that we are interested in. This of course resolve tasks and breaks task configuration avoidance.In order to handle this, we need to know more about how Ktlint tasks are created. With the latest versions, they are created per source set which is pretty consistent with other tools configurations we have
This is why support for version 6.1 is removed.
Additionally
Also added try-catch for any future exceptions with a clear output of the current state with clear message of which versions of Ktlint and Detekt we support.
Final screenshot:
All tools enabled from
sampleand majority of the tasks are avoided