Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Feature: Add support for fatal lint #105

Merged
merged 2 commits into from
May 25, 2018
Merged

Feature: Add support for fatal lint #105

merged 2 commits into from
May 25, 2018

Conversation

tomsammons
Copy link

Fatal lint errors currently do not contribute to our total error count.

This PR:

  • Adds in a fatal error to our lint results
  • Adds fatal errors to our total errors count
  • Modifies the integration test to reflect this

@joetimmins joetimmins self-requested a review May 25, 2018 09:44
@joetimmins joetimmins self-assigned this May 25, 2018
joetimmins
joetimmins approved these changes May 25, 2018
View reviewed changes
Copy link

@joetimmins joetimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 good groovying

@rock3r rock3r self-requested a review May 25, 2018 09:45
@rock3r rock3r merged commit 3866215 into develop May 25, 2018
@rock3r rock3r deleted the feature/add_support_for_fatal_lint branch May 25, 2018 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rock3r rock3r rock3r approved these changes

@joetimmins joetimmins joetimmins approved these changes

Assignees

@joetimmins joetimmins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomsammons @rock3r @joetimmins