This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Add multi-module sample project #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-archano
previously approved these changes
Mar 16, 2018
rock3r
reviewed
Mar 17, 2018
sample-multi-module/build.gradle
Outdated
| mavenCentral() | ||
| } | ||
| } | ||
|
|
|
|
||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:3.0.1' | ||
| classpath "gradle.plugin.io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.0.0.RC6-3" |
There was a problem hiding this comment.
seems to be breaking the plugin 🙀
A problem occurred evaluating script.
> Could not find method systemOrDefaultProfile() for arguments [] on DetektExtension(...)
| "$p.name:assemble" | ||
| }) | ||
|
|
||
| task build(dependsOn: ['assemble', 'check']) |
There was a problem hiding this comment.
Are we sure we need these three tasks? Isn't it the default behaviour?
There was a problem hiding this comment.
right. the way we refer to the tasks just needs some changing.
rock3r
approved these changes
Mar 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As setting up SAP on a multi-module project can be a bit tricky (or not very straight-forward) a sample project showcasing this sort of setup can be very helpful for people that want to use the plugin under such conditions.
The multi-module sample is a copy of the already existing sample, with an added (Java) module and the required changes to the SAP setup.