feat: add sub function #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aster-sam into feat/getatt-intrinsic-function
…ter-sam into feat/join-intrinsic-function
faster_sam/cloudformation.py
Outdated
| for match in matches: | ||
| if match in os.environ: | ||
| env_var = os.environ[match] | ||
| return string.replace(f"${{{match}}}", env_var) |
There was a problem hiding this comment.
Dessa maneira o código não vai sempre retornar após encontrar o primeiro match no ambiente?
… into feat/add-sub-function
faster_sam/cloudformation.py
Outdated
|
|
||
| pattern = r"\${(.*?)}" | ||
|
|
||
| def replace(string: str, matches: List[Any]): |
There was a problem hiding this comment.
Acho que vale a pena tirar essa função daqui e adicionar um teste unitário, se alguém alterar ela e adicionar um bug pode passar despercebido já que ela é testado só pela função acima dela.
ttamurajr
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contain
Details