Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function score modes #60

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Conversation

CheapHasz
Copy link
Collaborator

As seen here, BoostMode and ScoreMode are necessary to manipulate the interactions of multiple function scores.

Therefore I added a FunctionScoreOptions to handle every possible functione score option in the QueryBuilder

@CheapHasz CheapHasz requested a review from skwi February 8, 2019 15:22
@CheapHasz
Copy link
Collaborator Author

As a side note, I think it would be beneficial to harmonize the constructor assertions like in the last commit , and add the missing constants (like GeoDistanceFilter units, for exemple).

Would you be ok with me doing a cleaning PR for that ?

Copy link
Member

@skwi skwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CheapHasz CheapHasz merged commit 47ec6da into novaway:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants