fix: rn build android (#785)

* fix: disable broken minification with proguard * revert: cat in ci
novasamatech · Jul 16, 2021 · e018b63 · e018b63
1 parent 05fe8d7
commit e018b63
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -32,7 +32,7 @@ android-build-release:
     paths:
       - signer-app-release-signed.apk
   script:
-    - echo "$KEYSTORE_DATA" | base64 -d > /tmp/gitlab-ci.keystore
+    - cat "$KEYSTORE_DATA" | base64 -d > /tmp/gitlab-ci.keystore
     - wc /tmp/gitlab-ci.keystore
     - ./scripts/build-release.sh /tmp/gitlab-ci.keystore "$KEYSTORE_ALIAS" "$KEYSTORE_PASS"
   tags:

diff --git a/android/app/build.gradle b/android/app/build.gradle
@@ -168,10 +168,10 @@ android {
             // Caution! In production, you need to generate your own keystore file.
             // see https://facebook.github.io/react-native/docs/signed-apk-android.
             // signingConfig signingConfigs.debug
-             minifyEnabled enableProguardInReleaseBuilds
-             proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
+            // minifyEnabled enableProguardInReleaseBuilds
+            // proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
             // Detox-specific additions to pro-guard, uncomment following line if pro-guard is enabled.
-             proguardFile "${rootProject.projectDir}/../node_modules/detox/android/detox/proguard-rules-app.pro"
+            // proguardFile "${rootProject.projectDir}/../node_modules/detox/android/detox/proguard-rules-app.pro"
         }
     }
     splits {

diff --git a/android/gradle.properties b/android/gradle.properties
@@ -21,6 +21,5 @@ MYAPP_RELEASE_STORE_FILE=apk.keystore
 MYAPP_RELEASE_KEY_ALIAS=testing
 MYAPP_RELEASE_STORE_PASSWORD=testing
 MYAPP_RELEASE_KEY_PASSWORD=testing
-android.enableR8=false
 android.useAndroidX=true
 android.enableJetifier=true