Make this RFC be again about a single method #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should make no difference in speed, but is slightly cleaner.
novalis
added a commit
that referenced
this pull request
Jul 17, 2015
Make this RFC be again about a single method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that having both
read_exactandread_fullin the same RFC was a mistake, and only muddled the issue. It would be better to make this one be again aboutwrite_all's direct counterpart, and let someone else write a RFC for the proposedread_fullmethod.If you agree with that, please merge this pull request into yours so the discussion can continue at rust-lang#980 instead of splitting the discussion; if you disagree, tell me so I can open a separate pull request.