Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dockerignore #7

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Add dockerignore #7

merged 2 commits into from
Apr 24, 2023

Conversation

pysel
Copy link

@pysel pysel commented Apr 24, 2023

adds dockerignore

@pysel pysel mentioned this pull request Apr 24, 2023
Closed
faddat
faddat requested changes Apr 24, 2023
View reviewed changes
Copy link

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should include these folders:

  • tests
  • testutil
  • legacy_ibc_testing
  • docs
  • scripts

because we build inside docker and I think those are all used in the container.

@pysel pysel merged commit 9d7d2c4 into sdk-47-fifth-go-notional Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pysel @faddat