Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change in SDK #4

Merged
merged 1 commit into from
Apr 24, 2023
Merged

API change in SDK #4

merged 1 commit into from
Apr 24, 2023

Conversation

vuong177
Copy link

@vuong177 vuong177 commented Apr 24, 2023 •
edited
Loading

  • Slash() function
  • change GetParam to comply with staking interface restriction
  • add GetConsumerParam to get consumer module params

@vuong177 vuong177 changed the title slash functoin fix by fork sdk API change in SDK Apr 24, 2023
faddat
faddat requested changes Apr 24, 2023
View reviewed changes
Copy link

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vuong or Ruslan, please describe the api changes made, so we can link this PR to the one on ics itself.

@vuong177 vuong177 merged commit e67ec72 into sdk-47-fifth-go-notional Apr 24, 2023
@faddat faddat mentioned this pull request Apr 24, 2023
Closed
18 tasks
@pysel pysel mentioned this pull request Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat requested changes

@sontrinh16 sontrinh16 sontrinh16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuong177 @faddat @sontrinh16