Remove anymap #307
Merged
Remove anymap #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickt
force-pushed
the
remove-anymap
branch
2 times, most recently
from
5cfe83b to
6669bd4
Compare
`anymap` has some undefined behavior, and appears to no longer be maintained. This patch replaces anymap with an opaque `EventAttributes` type, which contains a number of accessor methods to get and set values. Under the covers, this type is simply a box of a struct of option types. However, since it's opaque the underlying type could be swapped out with an alternative type that can be extended to support more attributes without breaking users. Closes notify-rs#306
|
Thanks for the review @0xpr03! I've added a line to the changelog. |
|
Hey thanks for changing. This also needs the URL like the other line with a PR link. |
0xpr03
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anymaphas some undefined behavior, and appears to no longer be maintained.This patch replaces anymap with an opaque
Attributestype, which contains anumber of accessor methods to get and set values. Under the covers, this type
is simply a box of a struct of option types. However, since it's opaque the
underlying type could be swapped out with an alternative type that can be
extended to support more attributes without breaking users.
Closes #306