-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for errors from str_path_to_cfstring_ref
.
#302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this fixes it or rather just works in case the race condition for our runtime panic isn't triggered ?
@@ -281,6 +281,10 @@ impl FsEventWatcher { | |||
unsafe { | |||
let mut err: cf::CFErrorRef = ptr::null_mut(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably investigate whether this should be handled instead of ignored (and deallocated)
Medium-high confidence that this fixes the actual problem. Here's the evidence:
To get a bit more confidence, one could write a program that passes a null second argument to |
Signed-off-by: Aron Heinecke <[email protected]>
Closes #301.