Fix leak on windows, porting #288 to v5 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aron Heinecke <[email protected]>
|
Looks correct to me. |
kjeremy
added a commit
to kjeremy/rust-analyzer
that referenced
this pull request
Apr 15, 2021
Fixes windows leak: notify-rs/notify#298
bors bot
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Apr 15, 2021
8529: notify 5.0.0.pre7 r=kjeremy a=kjeremy Fixes windows leak: notify-rs/notify#298 Co-authored-by: kjeremy <[email protected]>
bors bot
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Apr 15, 2021
8529: minor: notify 5.0.0.pre7 r=kjeremy a=kjeremy Fixes windows leak: notify-rs/notify#298 Co-authored-by: kjeremy <[email protected]>
Veykril
pushed a commit
to Veykril/rust-analyzer
that referenced
this pull request
Apr 17, 2021
Fixes windows leak: notify-rs/notify#298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the windows specific part of #287
cc @Awfa