Backport #285 display correct inotify limit error

[0xpr03]

Backport #285 to v4.

This approach is API breaking in one way or another. If we add another error kind (as #285 does), we break the error-API and if we use this approach by utilizing Error::Generic we make it harder to catch and also will break user code that may check for this exact error-no case to display user friendly errors. I think it'd be better to introduce a new error case, but this approach technically does not break semver.

[0xpr03]

my editor doesn't seem to like this line..

[JohnTitor]

👍

I think it'd be better to introduce a new error case, but this approach technically does not break semver.

We're going to v5 so this is still reasonable for me as a "patch".

[0xpr03]

👍

I think it'd be better to introduce a new error case, but this approach technically does not break semver.

We're going to v5 so this is still reasonable for me as a "patch".

I'm not sure I understand what you mean. That we're going towards a stable v5 ? Because this is the backport for v4.

[JohnTitor]

I mean, we don't have to introduce a new error structure for v4 as it's passive-developed now (sorry if my wording is strange, I'm not a native speaker :/).

[JohnTitor]

Btw, I noticed this breaks our MSRV.

error: attributes are not yet allowed on `if` expressions
   --> src/lib.rs:524:9
    |
524 |         #[cfg(target_os = "linux")]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to previous error

So it should be:

Suggested change

	#[cfg(target_os = "linux")]
	if err.raw_os_error() == Some(28) {
	return Error::Generic(String::from("Can't watch (more) files, limit on the total number of inotify watches reached"))
	}
	#[cfg(target_os = "linux")]
	{
	if err.raw_os_error() == Some(28) {
	return Error::Generic(String::from("Can't watch (more) files, limit on the total number of inotify watches reached"))
	}
	}

[0xpr03]

Ah ok makes sense, I'm not a native one either ;) I'll fix that suggestion (and CI failure) and then merge.

[JohnTitor]

Ugh:

I forgot to backport #277 to v4, will do later.