Fix AttributeError/Remove use of NoteableKernelManager #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlrobins
approved these changes
Jul 20, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 60.34% 60.53% +0.18%
==========================================
Files 19 18 -1
Lines 1044 973 -71
==========================================
- Hits 630 589 -41
+ Misses 414 384 -30
|
rohitsanj
commented
Jul 20, 2023
| @@ -90,8 +80,9 @@ async def test_default_client(mocker, file, file_content, noteable_engine): | |||
| noteable_nb=file_content, | |||
| logger=logging.getLogger(__name__), | |||
| ) | |||
| noteable_engine.client.get_or_launch_ready_kernel_session.assert_called_once() | |||
There was a problem hiding this comment.
This assert tests the changed diff above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[0.0.29] - 2023-07-20
Removed
NoteableKernelManagerto reduce unnecessary abstractionsFixed
AttributeErroron trying to fetchNoteableClient.file_session_cachewhich has been removed. Determine kernels channel id from file_id instead.