Adding verify blob commands #889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishab Semlani <[email protected]>
Signed-off-by: Rishab Semlani <[email protected]>
Signed-off-by: Rishab Semlani <[email protected]>
Signed-off-by: Rishab Semlani <[email protected]>
rrsemlani
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
SteveLasker,
toddysm and
Two-Hearts
as code owners
| Long: longMessage, | ||
| Args: func(cmd *cobra.Command, args []string) error { | ||
| if len(args) == 0 { | ||
| return errors.New("missing signature/blob path to the artifact: use `notation blob verify --help` to see what parameters are required") |
There was a problem hiding this comment.
Suggested change
| return errors.New("missing signature/blob path to the artifact: use `notation blob verify --help` to see what parameters are required") | |
| return errors.New("missing signature/blob path to the artifact: use `notation blob verify --help` to see what parameters are required") |
Suggested change
| return errors.New("missing signature/blob path to the artifact: use `notation blob verify --help` to see what parameters are required") | |
| return errors.New("missing blob path: use `notation blob verify --help` to see what parameters are required") |
Comment on lines
+64
to
+65
| opts.signaturePath = args[0] | ||
| opts.blobPath = args[0] |
There was a problem hiding this comment.
why are we adding blob path to signature path ?
Comment on lines
+69
to
+71
| if opts.maxSignatureAttempts <= 0 { | ||
| return fmt.Errorf("max-signatures value %d must be a positive number", opts.maxSignatureAttempts) | ||
| } |
| return runVerify(cmd, opts) | ||
| }, | ||
| } | ||
| command.Flags().StringArrayVar(&opts.pluginConfig, "plugin-config", nil, "{key}={value} pairs that are passed as it is to a plugin, if the verification is associated with a verification plugin, refer plugin documentation to set appropriate values") |
There was a problem hiding this comment.
are we missing opts.LoggingFlagOpts.ApplyFlags(command.Flags()) ?
also one for signature path and policy name?
| } | ||
| command.Flags().StringArrayVar(&opts.pluginConfig, "plugin-config", nil, "{key}={value} pairs that are passed as it is to a plugin, if the verification is associated with a verification plugin, refer plugin documentation to set appropriate values") | ||
| cmd.SetPflagUserMetadata(command.Flags(), &opts.userMetadata, cmd.PflagUserMetadataVerifyUsage) | ||
| command.Flags().IntVar(&opts.maxSignatureAttempts, "max-signatures", 100, "maximum number of signatures to evaluate or examine") |
|
This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days. |
|
PR closed due to no activity in the past 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding verify blob commands.
Spec Pr used for ref: #811