Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:updating go.mod dependencies for alpha4 #357

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

chloeyin
Copy link
Contributor

@chloeyin chloeyin commented Sep 26, 2022

This PR updates notation cli with the main branch of notation-core-go and notation-go.
After all PRs merged, I will update go.mod to use main branch.
Test manually on virtual machine.
Now I hard code envelope type to be jws. I will add more envelope types after cose merged.
Signed-off-by: zaihaoyin [email protected]

@chloeyin chloeyin changed the title feat:updating go.mod dependencies feat:updating go.mod dependencies for alpha4 Sep 26, 2022
@chloeyin chloeyin marked this pull request as ready for review September 27, 2022 02:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #357 (6e399b3) into main (8e43968) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   30.62%   30.54%   -0.08%     
==========================================
  Files          25       25              
  Lines        1610     1614       +4     
==========================================
  Hits          493      493              
- Misses       1104     1108       +4     
  Partials       13       13              
Impacted Files Coverage Δ
cmd/notation/verify.go 18.62% <0.00%> (-0.38%) ⬇️
internal/cmd/signer.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 675bd4b into notaryproject:main Sep 27, 2022
@vaninrao10
Copy link
Contributor

@priteshbandi since #347 is tracked as part of this Pull request, should we close #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants