-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:updating go.mod dependencies for alpha4 #357
Conversation
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 30.62% 30.54% -0.08%
==========================================
Files 25 25
Lines 1610 1614 +4
==========================================
Hits 493 493
- Misses 1104 1108 +4
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: zaihaoyin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@priteshbandi since #347 is tracked as part of this Pull request, should we close #347 |
This PR updates notation cli with the main branch of
notation-core-go
andnotation-go
.After all PRs merged, I will update go.mod to use main branch.
Test manually on virtual machine.
Now I hard code envelope type to be jws. I will add more envelope types after cose merged.
Signed-off-by: zaihaoyin [email protected]