Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix usage of SignerInfo.AuthenticSigningTime #424

Merged
merged 6 commits into from
Jul 19, 2024
Merged

fix: fix usage of SignerInfo.AuthenticSigningTime #424

merged 6 commits into from
Jul 19, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jul 16, 2024 •
edited
Loading

This PR updates the use of SignerInfo.AuthenticSigningTime due to upgrade of notation-core-go.

@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (8ada12a) to head (3158202).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   80.76%   80.75%   -0.01%     
==========================================
  Files          33       33              
  Lines        2449     2448       -1     
==========================================
- Hits         1978     1977       -1     
  Misses        331      331              
  Partials      140      140

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Two-Hearts Two-Hearts changed the title fix: fix revocation authentic signing time fix: fix SignerInfo.AuthenticSigningTime Jul 16, 2024
@Two-Hearts Two-Hearts changed the title fix: fix SignerInfo.AuthenticSigningTime fix: fix usage of SignerInfo.AuthenticSigningTime Jul 16, 2024
shizhMSFT
shizhMSFT reviewed Jul 16, 2024
View reviewed changes
priteshbandi
priteshbandi reviewed Jul 16, 2024
View reviewed changes
@Two-Hearts
update
1c7e785 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
update
4e7026d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
3158202 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts dismissed stale reviews from JeyJeyGao and shizhMSFT via 3158202 July 19, 2024 00:48
JeyJeyGao
JeyJeyGao approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 8340920 into notaryproject:main Jul 19, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the authenticSigningTime branch July 19, 2024 04:57
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Two-Hearts @priteshbandi @shizhMSFT @JeyJeyGao