-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor:support cose signature format #127
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 72.66% 74.68% +2.01%
==========================================
Files 36 39 +3
Lines 2491 2666 +175
==========================================
+ Hits 1810 1991 +181
+ Misses 544 525 -19
- Partials 137 150 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR has been split into #131 and other smaller PRs. |
Signed-off-by: zaihaoyin <[email protected]>
Signed-off-by: zaihaoyin <[email protected]>
Signed-off-by: zaihaoyin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor
notation-go
to support cose envelopeBackground can be checked out in notaryproject/notation#278
Currently it uses dependencies from cose branch
Major Changes
github.com/notaryproject/notation-core-go/signature
to sign and verifyrunner
andsigner
to aprovider
forpluginSigner
to sign and removepluginSigProvider
builtinProvider
to support local signing andexternalProvider
to support signing by pluginVerificationPlugin
andVerificationPluginMinVersion
toExtendedAttributes
VerificationPlugin
andVerificationPluginMinVersion
by callingsignerInfo.ExtendedAttribute
SignatureMediaType
toPutSignatureManifest
to support different types of signaturesGuessSignatureEnvelopeFormat
to inspect signature (This function may change later to better inspect a signature)Suggested review order
Signed-off-by: zaihaoyin [email protected]