Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Github Action for notation setup #5

Merged
merged 20 commits into from
Jul 24, 2023
Merged

feat: Add Github Action for notation setup #5

merged 20 commits into from
Jul 24, 2023

Conversation

duffney
Copy link
Contributor

@duffney duffney commented Jul 7, 2023

Contributing setup-notation as notation-action.

@duffney duffney changed the title feat: Notation CLI GitHub Action feat: Install Notation CLI GitHub Action Jul 7, 2023
@duffney duffney changed the title feat: Install Notation CLI GitHub Action feat: Add Github Action for notation setup Jul 7, 2023
duffney added 2 commits July 7, 2023 12:20
@duffney
initial commit
fb08c9a 
Signed-off-by: Joshua Duffney <[email protected]>
@duffney
Move action to subdir
e976ac8 
Signed-off-by: Joshua Duffney <[email protected]>
JeyJeyGao
JeyJeyGao reviewed Jul 10, 2023
View reviewed changes
Two-Hearts
Two-Hearts reviewed Jul 10, 2023
View reviewed changes
shizhMSFT
shizhMSFT reviewed Jul 10, 2023
View reviewed changes
duffney and others added 11 commits July 10, 2023 13:16
@duffney
Update git url
5846028 
Signed-off-by: Joshua Duffney <[email protected]>
@duffney
Mod: remove mapArch func
7e09c46 
Signed-off-by: Joshua Duffney <[email protected]>
@duffney
Mod: remove dupliacte version check
9d1056c 
Signed-off-by: Joshua Duffney <[email protected]>
@duffney @Two-Hearts
Remove unused const
faae507 
Co-authored-by: Patrick Zheng <[email protected]>
Signed-off-by: Josh Duffney <[email protected]>
@duffney @Two-Hearts
Remove comment
02c23ee 
Co-authored-by: Patrick Zheng <[email protected]>
Signed-off-by: Josh Duffney <[email protected]>
@duffney
Mod: change name to setup
fd79ee2 
Signed-off-by: Joshua Duffney <[email protected]>
@duffney
Merge branch 'main' of https://github.com/duffney/notation-action
1781eba
@duffney
add readme
9516cfb 
Signed-off-by: Joshua Duffney <[email protected]>
@duffney
Mod: remove version check
e2f7f9b 
Signed-off-by: Joshua Duffney <[email protected]>
@duffney @Two-Hearts
Add build to package scripts
f95cac1 
Co-authored-by: Patrick Zheng <[email protected]>
Signed-off-by: Josh Duffney <[email protected]>
@duffney @Two-Hearts
Remove plugin inputs
645b784 
Co-authored-by: Patrick Zheng <[email protected]>
Signed-off-by: Josh Duffney <[email protected]>
Two-Hearts
Two-Hearts reviewed Jul 12, 2023
View reviewed changes
@duffney
Mod: run npm run build
2e0498d 
Signed-off-by: Joshua Duffney <[email protected]>
Two-Hearts
Two-Hearts reviewed Jul 13, 2023
View reviewed changes
duffney and others added 4 commits July 14, 2023 09:39
@duffney @Two-Hearts
Remove cert generation
e29d858 
Co-authored-by: Patrick Zheng <[email protected]>
Signed-off-by: Josh Duffney <[email protected]>
@duffney @Two-Hearts
Replace fs.rename with mv
4f163e0 
Co-authored-by: Patrick Zheng <[email protected]>
Signed-off-by: Josh Duffney <[email protected]>
@duffney
Remove plugin install logic
9ef753c 
Signed-off-by: Joshua Duffney <[email protected]>
@duffney
Remove getPluginDownloadObject export
201787f 
Signed-off-by: Joshua Duffney <[email protected]>
Two-Hearts
Two-Hearts reviewed Jul 17, 2023
View reviewed changes
@duffney
Remove unused imports
b60117e 
Signed-off-by: Joshua Duffney <[email protected]>
Two-Hearts
Two-Hearts approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Jul 20, 2023
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as the first iteration. We should convert all unresolved conversation as issues, merge this PR, and open other PRs to address them.

@Two-Hearts
Copy link
Contributor

@duffney There's a conflict in the README file of your PR. Could you resolve it so that we can merge? Thanks.

@duffney
Merge branch 'main' into main
31d88f6 
Signed-off-by: Josh Duffney <[email protected]>
@duffney duffney requested a review from a team as a code owner July 21, 2023 13:43
@Two-Hearts Two-Hearts merged commit f5519cf into notaryproject:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou left review comments

@JeyJeyGao JeyJeyGao JeyJeyGao left review comments

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@duffney @Two-Hearts @shizhMSFT @FeynmanZhou @JeyJeyGao